Fix ssh hostkeys export after merging #423 - #429
Merged
Conversation
Without the workaround, we should use the ssh key type stored in the fact, as `ecdsa` isn't a valid key type. See https://www.puppet.com/docs/puppet/7/core_facts.html#ssh for valid names in the `ssh` fact
saz
force-pushed
the
fix-hostkeys-export
branch
from
October 28, 2025 16:35
e0fc4ba to
54cbed2
Compare
cvquesty
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the workaround, we should use the ssh key type stored in the fact, as
ecdsaisn't a valid key type.See https://www.puppet.com/docs/puppet/7/core_facts.html#ssh for valid names in the
sshfactPull Request (PR) description
This Pull Request (PR) fixes the following issues